fix: allow editing teams after match generation #36

Merged

dev-bot merged 11 commits from fix/edit-teams-after-match-generation into main 2026-08-20 14:49:01 -04:00

Conversation 0 Commits 11 Files changed 6 +140 -48

dev-bot commented 2026-08-14 18:35:04 -04:00

Collaborator

Copy link

Summary

• Allow existing teams to be edited after matches are generated.
• Prevent adding or removing teams after match generation.
• Detect the lock from generated matches rather than saved stages.
• Add backend and frontend coverage for post-generation team edits.

Verification

• npm run build -- --configuration development
• npm test -- --watch=false (50 tests passed)
• go test ./internal/backend ./migrations

Manual testing checklist

• Sign in as an operator and create an event with at least two teams.
• Configure a stage and generate its matches.
• Return to the Teams page and confirm the message says teams cannot be added or removed after matches are generated.
• Confirm the player/signup and create-team controls are unavailable, and the Remove action is unavailable.
• Edit an existing team’s name and/or players, save it, and confirm the updated team appears in the list.
• Reload the Teams page and confirm the team edit persisted.
• Open the Matches page and confirm the edited team is still shown correctly in generated matches.
• Before generating matches in a separate event, confirm teams can still be added, edited, and removed.

## Summary - Allow existing teams to be edited after matches are generated. - Prevent adding or removing teams after match generation. - Detect the lock from generated matches rather than saved stages. - Add backend and frontend coverage for post-generation team edits. ## Verification - `npm run build -- --configuration development` - `npm test -- --watch=false` (50 tests passed) - `go test ./internal/backend ./migrations` ## Manual testing checklist - [x] Sign in as an operator and create an event with at least two teams. - [x] Configure a stage and generate its matches. - [x] Return to the Teams page and confirm the message says teams cannot be added or removed after matches are generated. - [x] Confirm the player/signup and create-team controls are unavailable, and the Remove action is unavailable. - [x] Edit an existing team’s name and/or players, save it, and confirm the updated team appears in the list. - [x] Reload the Teams page and confirm the team edit persisted. - [x] Open the Matches page and confirm the edited team is still shown correctly in generated matches. - [x] Before generating matches in a separate event, confirm teams can still be added, edited, and removed.

dev-bot added 3 commits 2026-08-14 18:35:04 -04:00

fix: allow editing teams after match generation ... 41b6115cd3

Amp-Thread-ID: https://ampcode.com/threads/T-01a00004-afec-712a-a139-0e0e060908f2
Co-authored-by: Addison Emig <[email protected]>

test: cover editing teams after matches ... 6ca25d04e3

Amp-Thread-ID: https://ampcode.com/threads/T-01a00004-afec-712a-a139-0e0e060908f2
Co-authored-by: Addison Emig <[email protected]>

fix: clarify locked team message ... 00b89a72fb

Amp-Thread-ID: https://ampcode.com/threads/T-01a00004-afec-712a-a139-0e0e060908f2
Co-authored-by: Addison Emig <[email protected]>

dev-bot added 1 commit 2026-08-20 05:41:47 -04:00

test: update registration load key expectation ... 7fadf943b8

Amp-Thread-ID: https://ampcode.com/threads/T-01a00004-afec-712a-a139-0e0e060908f2
Co-authored-by: Addison Emig <[email protected]>

addison added 1 commit 2026-08-20 06:11:38 -04:00

Merge branch 'main' into fix/edit-teams-after-match-generation 0dd4152d3d

dev-bot added 2 commits 2026-08-20 06:15:02 -04:00

ci: enable orb sign-in for browser tests ... 3e0d5396d2

Amp-Thread-ID: https://ampcode.com/threads/T-01a00004-afec-712a-a139-0e0e060908f2
Co-authored-by: Addison Emig <[email protected]>

Merge remote-tracking branch 'origin/fix/edit-teams-after-match-generation' into fix/edit-teams-after-match-generation 82b0ce9909

dev-bot added 1 commit 2026-08-20 06:16:35 -04:00

ci: keep Orb-only sign-in out of CI ... 8b3827ebd6

Amp-Thread-ID: https://ampcode.com/threads/T-01a00004-afec-712a-a139-0e0e060908f2
Co-authored-by: Addison Emig <[email protected]>

dev-bot added 1 commit 2026-08-20 06:20:53 -04:00

feat: add late players to existing teams ... 25bc9c7ae3

Amp-Thread-ID: https://ampcode.com/threads/T-01a00004-afec-712a-a139-0e0e060908f2
Co-authored-by: Addison Emig <[email protected]>

dev-bot added 1 commit 2026-08-20 08:20:59 -04:00

fix: remove incorrect registration step labels ... 3ecd17259c

Amp-Thread-ID: https://ampcode.com/threads/T-01a00004-afec-712a-a139-0e0e060908f2
Co-authored-by: Addison Emig <[email protected]>

dev-bot added 1 commit 2026-08-20 14:44:14 -04:00

test: avoid Orb-specific sign-in assertion ... e88f58e30a

Amp-Thread-ID: https://ampcode.com/threads/T-01a00004-afec-712a-a139-0e0e060908f2
Co-authored-by: Addison Emig <[email protected]>

dev-bot merged commit a4a5c0756f into main 2026-08-20 14:49:01 -04:00

dev-bot referenced this pull request from a commit 2026-08-20 14:49:03 -04:00

fix: allow editing teams after match generation (#36)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

kwila/tournaments!36

No description provided.