feat: building record management (spec 1.4) #8

Merged

addison merged 22 commits from implement-spec-1-4-building-management into main 2026-07-03 16:32:29 -04:00

Conversation 0 Commits 22 Files changed 28 +2400 -54

dev-bot commented 2026-07-03 11:42:16 -04:00

Collaborator

Copy link

Implements spec 1.4 Building Record Management.

Backend

• New internal/api package with a generic CRUD wiring abstraction: shared routing, JSON decoding, status codes, and error mapping; per-resource adapters and validation hooks.
• Full CRUD under /api/buildings, /api/customers, /api/models, /api/features; read-only /api/statuses.
• All backend services now mount under one /api namespace; update service migrated from /updates-api to /api/updates.
• Building delete goes through the single coordinated Store.DeleteBuilding.
• Error mapping: 404 not found, 400 validation, 409 duplicate serial, 503 storage unavailable.
• Bugfix: DeleteBuilding leaked its transaction on the not-found path, deadlocking the single-connection SQLite store.

Frontend

• Sidebar: Buildings, Customers, Models, Features, Updates.
• Shared ResourceCrudPage for customers/models/features (table, modal editor, confirmed deletes).
• Building form per spec: serial, integer length/width, color free-text autocomplete, model/customer comboboxes with inline add-new, status select, feature multi-select with inline add, notes.
• Buildings list with search and resolved names; rewritten detail page with Edit/Delete.

Testing

• 14 API tests (httptest against a temp-dir store): CRUD round-trips, feature/customer/model/status attachment, 404/400/409/503 paths.
• go test ./..., go vet ./..., frontend build all pass; UI verified end-to-end in the running app.

Spec remains in-progress; will flip to completed after merge.

Implements [spec 1.4 Building Record Management](specs/001-mvp/004-building-record-management/SPEC.md). ## Backend - New `internal/api` package with a generic CRUD wiring abstraction: shared routing, JSON decoding, status codes, and error mapping; per-resource adapters and validation hooks. - Full CRUD under `/api/buildings`, `/api/customers`, `/api/models`, `/api/features`; read-only `/api/statuses`. - All backend services now mount under one `/api` namespace; update service migrated from `/updates-api` to `/api/updates`. - Building delete goes through the single coordinated `Store.DeleteBuilding`. - Error mapping: 404 not found, 400 validation, 409 duplicate serial, 503 storage unavailable. - Bugfix: `DeleteBuilding` leaked its transaction on the not-found path, deadlocking the single-connection SQLite store. ## Frontend - Sidebar: Buildings, Customers, Models, Features, Updates. - Shared `ResourceCrudPage` for customers/models/features (table, modal editor, confirmed deletes). - Building form per spec: serial, integer length/width, color free-text autocomplete, model/customer comboboxes with inline add-new, status select, feature multi-select with inline add, notes. - Buildings list with search and resolved names; rewritten detail page with Edit/Delete. ## Testing - 14 API tests (httptest against a temp-dir store): CRUD round-trips, feature/customer/model/status attachment, 404/400/409/503 paths. - `go test ./...`, `go vet ./...`, frontend build all pass; UI verified end-to-end in the running app. Spec remains `in-progress`; will flip to `completed` after merge.

dev-bot added 5 commits 2026-07-03 11:42:16 -04:00

feat: mark building record management spec in-progress ... c9c8146dfc

Co-authored-by: Shelley <[email protected]>

feat: building-management CRUD API under /api namespace ... 7cb155267c

Add internal/api with a shared generic CRUD abstraction: mount wires
list/create/read/update/delete routes per resource, with hook points
for validation and storage adapters. Buildings, customers, models, and
features share the same flow; statuses are exposed read-only.

Storage errors map to HTTP codes: not found 404, validation 400,
duplicate serial 409, storage unavailable 503. Building deletion goes
through the single Store.DeleteBuilding operation.

Also fix Store.DeleteBuilding leaving its transaction open on the
not-found path, which deadlocked the single-connection store.

Co-authored-by: Shelley <[email protected]>

feat: mount all backend services under one /api namespace ... 8b9e8f5baa

Replace the separate /updates-api and /api service routes with a
single /api service that owns an http.ServeMux routing to health,
updates (now /api/updates), and the building-management CRUD API.
Update the Updates page fetch calls to the new paths.

Co-authored-by: Shelley <[email protected]>

feat: sidebar sections and customer/model/feature CRUD pages ... 0cb7bad429

Add Customers, Models, and Features pages sharing one list+create+edit+delete component, expand the sidebar to all five sections, and scope New <resource> header actions per section.

Co-authored-by: Shelley <[email protected]>

feat: building list, detail, and create/edit form ... 3c4ff35f76

The buildings page lists serial, size, color, and resolved model/status/customer names with search and confirmed deletes. The create/edit form matches the spec's Building Form Shape: color autocomplete from existing values, model/customer/feature comboboxes with inline add-new, status select, and integer dimensions. The detail page shows resolved names with Edit and Delete affordances.

Co-authored-by: Shelley <[email protected]>

dev-bot added 3 commits 2026-07-03 13:59:53 -04:00

feat: use Immich Card, Alert, Text, and LoadingSpinner for page states ... 26f8cb6e1b

Replace hand-rolled bordered divs, heading/paragraph markup, and
AnnouncementBanner error strips with @immich/ui primitives:

- Card/CardHeader/CardTitle/CardDescription/CardBody for empty-state and
  not-found panels and the building detail layout
- Alert (warning) for storage-unavailable / backend-blocked states,
  Alert (danger) for load, delete, and form error banners
- Text/Heading/Stack/HStack instead of raw p/h2/dl styling classes
- LoadingSpinner + Text for loading indicators

Co-authored-by: Shelley <[email protected]>

feat: use Immich NumberInput and Alert in the building form ... a3fcfc84a9

- NumberInput with numeric bound values for length/width instead of
  string-typed Input type=number fields
- Alert for load/form error banners and the storage-unavailable state
- LoadingSpinner + Text loading indicator, HStack for the action row

Co-authored-by: Shelley <[email protected]>

feat: restyle combobox internals with Immich UI primitives ... 74e9aab14c

Evaluated replacing MultiCombobox with @immich/ui MultiSelect: its API is
options + bindable values over a bits-ui Select trigger with a fixed
option list — no text input for filtering and no way to render an inline
'create new' row, both of which the building form requires (spec 1.4
autocomplete + inline record creation). Same for the single Select.
Decision: keep our combobox components but build their internals from
library primitives instead of hand-rolled markup:

- ListButton for dropdown option rows and the 'Add …' create row
  (selected checkmark marks the current value in single-select)
- Badge with onClose for the removable selected-feature chips
- CloseButton for the clear-selection control
- Text for the 'No matches' empty row

Co-authored-by: Shelley <[email protected]>

dev-bot added 3 commits 2026-07-03 15:29:58 -04:00

docs(skill): prefer browser for exe.dev ui inspection ... 08e75dcf6e

Co-authored-by: Shelley <[email protected]>

fix(dev): proxy api through browser workflow ... 116e8a3211

Co-authored-by: Shelley <[email protected]>

fix(ui): center combobox clear button ... a3365e13d4

Co-authored-by: Shelley <[email protected]>

addison added 2 commits 2026-07-03 15:39:37 -04:00

fix: align table columns 0f76c4f0df

fix: improve table text contrast e20da41d25

addison added 1 commit 2026-07-03 15:40:52 -04:00

fix: move create actions into pages 7a4f7e0e31

addison added 1 commit 2026-07-03 15:41:51 -04:00

feat: add sidebar toggle 964b90cfdd

addison added 1 commit 2026-07-03 15:44:04 -04:00

fix: dialog 77243097c7

addison added 1 commit 2026-07-03 15:45:58 -04:00

fix: dialog 0aec15a439

addison added 1 commit 2026-07-03 15:48:09 -04:00

fix: detail page 5cdd304ad4

addison added 1 commit 2026-07-03 15:57:54 -04:00

fix: combobox a72658e367

addison added 1 commit 2026-07-03 15:58:53 -04:00

fix: status options 1197239a8d

addison added 2 commits 2026-07-03 16:08:11 -04:00

fix: use trailing close button in combobox 282d76ab6b

fix: consistent pages 4522236fa4

addison merged commit f3d9e156d5 into main 2026-07-03 16:32:29 -04:00

addison referenced this pull request from a commit 2026-07-03 16:32:31 -04:00

feat: building record management (spec 1.4) (#8)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

kwila/shed-ledger!8

No description provided.