kwila/office-extensions
Watch
1
0
Fork
You've already forked office-extensions
 0
Code Issues Pull requests 1 Projects Releases Packages Activity Actions

feat: add y-axis control presets to performance graphs #50

Merged
addison merged 4 commits from 005-002-003-graph-y-axis-control into main 2026-08-27 06:10:00 -04:00
Conversation 7 Commits 4 Files changed 8 +141 -16
talha commented 2026-08-27 03:54:22 -04:00
Collaborator
Copy link

Spec 5.2.3

Changes

  • Added y axis preset to performance graph and reflected that on print screen too.

Testing

  • Make sure you have latest code running.
  • Navigate to performance report page and There must be y axis preset dropdown on top left corner of graph.
  • Select different preset it must be applied to Y axis of gross profit graph.
  • With a preset selected other than automatic click on print button. Preset must be reflected there too.
# Spec 5.2.3 ## Changes - Added y axis preset to performance graph and reflected that on print screen too. ## Testing - [x] Make sure you have latest code running. - [x] Navigate to performance report page and There must be y axis preset dropdown on top left corner of graph. - [x] Select different preset it must be applied to Y axis of gross profit graph. - [x] With a preset selected other than automatic click on print button. Preset must be reflected there too.
feat: add y-axis control presets to performance graphs
All checks were successful
CI / frontend (pull_request) Successful in 38s
Details
CI / backend (pull_request) Successful in 35s
Details
Amp Review / review (pull_request) Successful in 1s
Details
c548640c14
addison commented 2026-08-27 05:34:25 -04:00
Owner
Copy link

Please resolve merge conflicts

Please resolve merge conflicts
Merge branch 'main' of https://git.kwila.cloud/kwila/office-extensions into 005-002-003-graph-y-axis-control
Some checks failed
CI / backend (pull_request) Has been cancelled
Details
CI / frontend (pull_request) Has been cancelled
Details
a342fcdc70
test(seed): add negative gross profit invoices
All checks were successful
Amp Review / review (pull_request) Successful in 1s
Details
CI / frontend (pull_request) Successful in 38s
Details
CI / backend (pull_request) Successful in 36s
Details
259c75037c 
Amp-Thread-ID: https://ampcode.com/threads/T-01a04295-6625-72bc-a603-6de8570ad1b7
Co-authored-by: Amp <[email protected]>
talha commented 2026-08-27 05:43:09 -04:00
Author
Collaborator
Copy link

@addison wrote in #50 (comment):

Please resolve merge conflicts

Done

@addison wrote in https://git.kwila.cloud/kwila/office-extensions/pulls/50#issuecomment-4406: > Please resolve merge conflicts Done
addison approved these changes 2026-08-27 05:43:23 -04:00
Dismissed
addison left a comment
Copy link

Nice job! I added a couple invoices with negative gross profit percentage to emulate the bad data the customer sometimes has (negative profit indicates that an invoice was entered in their system incorrectly).

Nice job! I added a couple invoices with negative gross profit percentage to emulate the bad data the customer sometimes has (negative profit indicates that an invoice was entered in their system incorrectly).
👍 1
addison commented 2026-08-27 05:45:00 -04:00
Owner
Copy link

One issue - selecting a new y-axis range should be a frontend-only change, but it is sending new requests to the backend. This will result in poor performance if the user is viewing hundreds of invoices for the past year.

One issue - selecting a new y-axis range should be a frontend-only change, but it is sending new requests to the backend. This will result in poor performance if the user is viewing hundreds of invoices for the past year.
addison requested changes 2026-08-27 05:45:25 -04:00
addison left a comment
Copy link

Please don't re-request backend data when applying new y-axis domain.

Please don't re-request backend data when applying new y-axis domain.
talha commented 2026-08-27 05:45:31 -04:00
Author
Collaborator
Copy link

@addison wrote in #50 (comment):

One issue - selecting a new y-axis range should be a frontend-only change, but it is sending new requests to the backend. This will result in poor performance if the user is viewing hundreds of invoices for the past year.

Let me fix this

@addison wrote in https://git.kwila.cloud/kwila/office-extensions/pulls/50#issuecomment-4411: > One issue - selecting a new y-axis range should be a frontend-only change, but it is sending new requests to the backend. This will result in poor performance if the user is viewing hundreds of invoices for the past year. Let me fix this
👍 1
fix: update performance page filter to prevent unnecessary refetching
All checks were successful
CI / frontend (pull_request) Successful in 37s
Details
CI / backend (pull_request) Successful in 36s
Details
a0ad40134b
talha commented 2026-08-27 05:57:01 -04:00
Author
Collaborator
Copy link

@addison wrote in #50 (comment):

Please don't re-request backend data when applying new y-axis domain.

done

@addison wrote in https://git.kwila.cloud/kwila/office-extensions/pulls/50#issuecomment-4412: > Please don't re-request backend data when applying new y-axis domain. done
talha requested review from addison 2026-08-27 05:57:06 -04:00
addison deleted branch 005-002-003-graph-y-axis-control 2026-08-27 06:10:00 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
addison
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kwila/office-extensions!50
No description provided.