feat: reusable filter handling #41

Merged

addison merged 9 commits from 004-004-reusable-filter-handling into main 2026-08-14 03:52:17 -04:00

Conversation 14 Commits 9 Files changed 16 +712 -260

talha commented 2026-08-11 13:46:39 -04:00

Collaborator

Copy link

Spec 4.4

Changes

• Added useURLFilters hook to handle filters.
• Added filter utils for job commisions and sales reports. and used reusable filter handling in job commisions and sales reports.

Testing

• Make sure you have latest code running.
• Navigate to job commissions and try applying different filters and see URL if both are synced and working fine.
• Now with some filters open print screen. Same filters must be in URL and same results must be shown for print.
• Repeat for sales reports.

# Spec 4.4 ## Changes - Added useURLFilters hook to handle filters. - Added filter utils for job commisions and sales reports. and used reusable filter handling in job commisions and sales reports. ## Testing - [x] Make sure you have latest code running. - [x] Navigate to job commissions and try applying different filters and see URL if both are synced and working fine. - [x] Now with some filters open print screen. Same filters must be in URL and same results must be shown for print. - [x] Repeat for sales reports.

talha added 2 commits 2026-08-11 13:46:39 -04:00

feat: implement reusable filter handling for job commissions and sales reports 4383d0a2a7

Merge branch 'main' of https://git.kwila.cloud/kwila/office-extensions into 004-004-reusable-filter-handling 8876131382

talha requested review from addison 2026-08-11 13:46:55 -04:00

addison commented 2026-08-11 18:46:01 -04:00

Owner

Copy link

Please fix title

Please fix title

talha changed title from 004-004-reusable-filter-handling to feat: reusable filter handling 2026-08-12 09:17:40 -04:00

addison added 1 commit 2026-08-13 03:39:05 -04:00

chore: merge main 379c11af2b

addison commented 2026-08-13 03:49:09 -04:00

Owner

Copy link

Added a couple unit tests to cover edge cases in the code...

Added a couple unit tests to cover edge cases in the code...

addison commented 2026-08-13 03:49:58 -04:00

Owner

Copy link

Also I found a bug in test - the user can't type a date because the page uses the new (invalid) date too quickly to load data.

I'll try to add a unit test for this one.

Also I found a bug in test - the user can't type a date because the page uses the new (invalid) date too quickly to load data. I'll try to add a unit test for this one.

dev-bot added 2 commits 2026-08-13 03:50:35 -04:00

test(filters): add URL filter regression coverage ... 5f8414ac8f

Amp-Thread-ID: https://ampcode.com/threads/T-019ff61f-c45c-721f-a12d-13a7454c1664
Co-authored-by: Addison Emig <[email protected]>

test(filters): inline hook test options ... 09b8156d6a

Amp-Thread-ID: https://ampcode.com/threads/T-019ff61f-c45c-721f-a12d-13a7454c1664
Co-authored-by: Addison Emig <[email protected]>

dev-bot added 1 commit 2026-08-13 04:10:06 -04:00

test(filters): defer date refresh until blur ... 4b7100ca4a

Amp-Thread-ID: https://ampcode.com/threads/T-019ff61f-c45c-721f-a12d-13a7454c1664
Co-authored-by: Addison Emig <[email protected]>

addison added 1 commit 2026-08-13 04:11:52 -04:00

Merge branch 'main' into 004-004-reusable-filter-handling 771645e7ef

addison requested changes 2026-08-13 04:12:47 -04:00

Dismissed

addison left a comment

Copy link

See my above comments. I tried to add test cases for each edge case, but the test cases might need fixed too. The start date typing one is tricky.

See my above comments. I tried to add test cases for each edge case, but the test cases might need fixed too. The start date typing one is tricky.

talha added 1 commit 2026-08-13 13:25:31 -04:00

feat(filters): enhance date handling to commit on change events 5b46c8ea9d

talha commented 2026-08-13 13:26:23 -04:00

Author

Collaborator

Copy link

@addison You might need to test again

@addison You might need to test again

talha requested review from addison 2026-08-13 13:26:58 -04:00

addison commented 2026-08-13 13:49:33 -04:00

Owner

Copy link

I still get early network request when I try to type "04 01 2026"

before I can fully type 2026, it does this:

I still get early network request when I try to type "04 01 2026" before I can fully type 2026, it does this: 

image.png

14 KiB

addison commented 2026-08-13 13:50:22 -04:00

Owner

Copy link

Also, just typing a 0 in the start date input makes it do a network request 🤔

Also, just typing a `0` in the start date input makes it do a network request 🤔

talha commented 2026-08-13 13:51:46 -04:00

Author

Collaborator

Copy link

@addison wrote in #41 (comment):

I still get early network request when I try to type "04 01 2026"

before I can fully type 2026, it does this:

Let me check what's issue
it might be bad idea to send request on date change

@addison wrote in https://git.kwila.cloud/kwila/office-extensions/pulls/41#issuecomment-3904: > I still get early network request when I try to type "04 01 2026" > > before I can fully type 2026, it does this: > > [](/kwila/office-extensions/attachments/d23fb575-5260-42f3-9693-ec0cc5e6c273) Let me check what's issue it might be bad idea to send request on date change

addison requested changes 2026-08-13 13:54:19 -04:00

Dismissed

addison left a comment

Copy link

Please add more test coverage and fix the bugs with requests being sent too early.

Please add more test coverage and fix the bugs with requests being sent too early.

addison commented 2026-08-13 13:55:07 -04:00

Owner

Copy link

it might be bad idea to send request on date change

I want to send request only when "full" date is entered 😅

Maybe we should just have an extra "apply date range" button that is only shown when dates are changed? but then how to make that look good 🤔

> it might be bad idea to send request on date change I want to send request only when "full" date is entered 😅 Maybe we should just have an extra "apply date range" button that is only shown when dates are changed? but then how to make that look good 🤔

talha commented 2026-08-13 13:57:11 -04:00

Author

Collaborator

Copy link

@addison wrote in #41 (comment):

it might be bad idea to send request on date change

I want to send request only when "full" date is entered 😅

Maybe we should just have an extra "apply date range" button that is only shown when dates are changed? but then how to make that look good 🤔

Let me see, what are the possibilities

@addison wrote in https://git.kwila.cloud/kwila/office-extensions/pulls/41#issuecomment-3908: > > it might be bad idea to send request on date change > > I want to send request only when "full" date is entered :sweat_smile: > > Maybe we should just have an extra "apply date range" button that is only shown when dates are changed? but then how to make that look good :thinking: Let me see, what are the possibilities

👍 1

talha added 1 commit 2026-08-13 14:16:46 -04:00

feat(filters): implement reusable date input handling with debounce 2298f1a335

talha commented 2026-08-13 14:17:59 -04:00

Author

Collaborator

Copy link

@addison I have added debounce + validation from 1970 to now plus 10 years, tell me please if it makes sense

@addison I have added debounce + validation from 1970 to now plus 10 years, tell me please if it makes sense

addison commented 2026-08-14 03:52:05 -04:00

Owner

Copy link

Wow, it works great!

Wow, it works great!

addison approved these changes 2026-08-14 03:52:10 -04:00

addison merged commit 01e2e7ee35 into main 2026-08-14 03:52:17 -04:00

addison deleted branch 004-004-reusable-filter-handling 2026-08-14 03:52:17 -04:00

addison referenced this pull request from a commit 2026-08-14 03:52:18 -04:00

feat: reusable filter handling (#41)

Sign in to join this conversation.

Reviewers

No reviewers

addison

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

kwila/office-extensions!41

No description provided.