kwila/market
1
0
Fork 1
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

feat: infrastructure setup for basic home page #15

Merged
Pertempto merged 19 commits from 0-infrastructure-setup into main 2025-11-08 21:27:40 -05:00
Conversation 6 Commits 19 Files changed 20 +10057 -11
Pertempto commented 2025-11-08 20:53:42 -05:00 (Migrated from github.com)
Copy link
No description provided.
github-actions[bot] commented 2025-11-08 20:55:27 -05:00 (Migrated from github.com)
Copy link

src/pages/index.astro — Input missing accessible label.

  • Placeholder-only inputs are not accessible to screen readers. Please add a visible <label for="search-input"> or an aria-label="Search" and give the input an id="search-input".
  • @Pertempto, please update the markup to ensure the search input is reachable by assistive tech.
`src/pages/index.astro` — Input missing accessible label. - Placeholder-only inputs are not accessible to screen readers. Please add a visible `<label for="search-input">` or an `aria-label="Search"` and give the input an `id="search-input"`. - @Pertempto, please update the markup to ensure the search input is reachable by assistive tech.
github-actions[bot] commented 2025-11-08 20:55:35 -05:00 (Migrated from github.com)
Copy link

Changes Requested

Please address these high-impact items before I approve:

  • Add an accessible hero input to src/pages/index.astro (visible <label for="search-input"> or aria-label + matching id) or update specs/000-mvp.md to uncheck/clarify the "Large input" item so the spec matches implementation.
  • Fix Tailwind/tooling: remove the incorrect @tailwindcss/vite / @tailwindcss/postcss usage, and either install/use @astrojs/tailwind in astro.config.mjs or configure Tailwind via PostCSS (install tailwindcss, postcss, autoprefixer) and replace @import "tailwindcss"; in src/styles/global.css with the Tailwind directives (@tailwind base; @tailwind components; @tailwind utilities;).
  • Verify wrangler.jsonc main and assets.directory match the actual output of astro build for the Cloudflare Workers adapter.

Summary of Changes

  • Added Astro project scaffold: astro.config.mjs, package.json, tsconfig.json, wrangler.jsonc, public/favicon.svg, docs (DEPLOYMENT.md, CONTRIBUTING.md, etc.).
  • Created marketing home page: src/pages/index.astro (hero, problems, solution, how-it-works, core values).
  • Added global stylesheet src/styles/global.css but it currently uses @import "tailwindcss";.
  • Updated MVP checklist (specs/000-mvp.md) marking infra items done (including a "Large input" item that isn't implemented in the page).

Overall Feedback

  • Negative: The PR currently contains two blocking issues — an accessible search/input is claimed in the MVP but missing from src/pages/index.astro, and the Tailwind integration is misconfigured (@tailwindcss/vite / @tailwindcss/postcss are not the correct Astro integrations). Both will break CI/accessibility checks and can cause build failures. Please fix these before merging.

  • Positive: Good scaffolding and clean marketing copy. The page layout and component structure are well organized and make future iteration straightforward. Nice work getting the initial site content and docs in place! 🚀

If you want, I can prepare a small patch that:

  • Inserts an accessible hero input under the hero header,
  • Replaces the Tailwind setup with @astrojs/tailwind and updates src/styles/global.css to use Tailwind directives.

Tag me (@Pertempto) once you push the fixes and I will re-review quickly.

# Changes Requested Please address these high-impact items before I approve: - Add an accessible hero input to `src/pages/index.astro` (visible `<label for="search-input">` or `aria-label` + matching `id`) or update `specs/000-mvp.md` to uncheck/clarify the "Large input" item so the spec matches implementation. - Fix Tailwind/tooling: remove the incorrect `@tailwindcss/vite` / `@tailwindcss/postcss` usage, and either install/use `@astrojs/tailwind` in `astro.config.mjs` or configure Tailwind via PostCSS (install `tailwindcss`, `postcss`, `autoprefixer`) and replace `@import "tailwindcss";` in `src/styles/global.css` with the Tailwind directives (`@tailwind base; @tailwind components; @tailwind utilities;`). - Verify `wrangler.jsonc` `main` and `assets.directory` match the actual output of `astro build` for the Cloudflare Workers adapter. ## Summary of Changes - Added Astro project scaffold: `astro.config.mjs`, `package.json`, `tsconfig.json`, `wrangler.jsonc`, `public/favicon.svg`, docs (`DEPLOYMENT.md`, `CONTRIBUTING.md`, etc.). - Created marketing home page: `src/pages/index.astro` (hero, problems, solution, how-it-works, core values). - Added global stylesheet `src/styles/global.css` but it currently uses `@import "tailwindcss";`. - Updated MVP checklist (`specs/000-mvp.md`) marking infra items done (including a "Large input" item that isn't implemented in the page). ## Overall Feedback - Negative: The PR currently contains two blocking issues — an accessible search/input is claimed in the MVP but missing from `src/pages/index.astro`, and the Tailwind integration is misconfigured (`@tailwindcss/vite` / `@tailwindcss/postcss` are not the correct Astro integrations). Both will break CI/accessibility checks and can cause build failures. Please fix these before merging. - Positive: Good scaffolding and clean marketing copy. The page layout and component structure are well organized and make future iteration straightforward. Nice work getting the initial site content and docs in place! 🚀 If you want, I can prepare a small patch that: - Inserts an accessible hero input under the hero header, - Replaces the Tailwind setup with `@astrojs/tailwind` and updates `src/styles/global.css` to use Tailwind directives. Tag me (@Pertempto) once you push the fixes and I will re-review quickly.
github-actions[bot] commented 2025-11-08 21:19:28 -05:00 (Migrated from github.com)
Copy link

@Pertempto — High-impact comments below.

File: src/pages/index.astro

  • The MVP checklist and CI note reference a "large input at the top of the page" / an accessible search input, but I don’t see any <input> in this file. Either:
    • Add the input in the hero (e.g. a search/create request field) and ensure it is accessible (visible <label for="search-input"> or aria-label="Search" plus id="search-input"), or
    • Uncheck/update the spec/checklist so it doesn’t claim the input exists.

This will resolve the accessibility warning and keep the spec accurate.

@Pertempto — High-impact comments below. File: `src/pages/index.astro` - The MVP checklist and CI note reference a "large input at the top of the page" / an accessible search input, but I don’t see any `<input>` in this file. Either: - Add the input in the hero (e.g. a search/create request field) and ensure it is accessible (visible `<label for="search-input">` or `aria-label="Search"` plus `id="search-input"`), or - Uncheck/update the spec/checklist so it doesn’t claim the input exists. This will resolve the accessibility warning and keep the spec accurate.
cloudflare-workers-and-pages[bot] commented 2025-11-08 21:21:36 -05:00 (Migrated from github.com)
Copy link

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs		 market 79f753f7 Commit Preview URL Nov 09 2025, 02:28 AM
## Deploying with &nbsp;<a href="https://workers.dev"><img alt="Cloudflare Workers" src="https://workers.cloudflare.com/logo.svg" width="16"></a> &nbsp;Cloudflare Workers The latest updates on your project. Learn more about [integrating Git with Workers](https://developers.cloudflare.com/workers/ci-cd/builds/git-integration/). | Status | Name | Latest Commit | Preview URL | Updated (UTC) | | -|-|-|-|-| | ✅ Deployment successful! <br>[View logs](https://dash.cloudflare.com/?to=/ef1b3f6f45e7d16874284a2637bec85b/workers/services/view/market/production/builds/4fa81913-08b8-42e6-9732-f8a9d7a041c2) | market | 79f753f7 | <a href='https://c8dacb9c-market.kwila-cloud.workers.dev'>Commit Preview URL</a> | Nov 09 2025, 02:28 AM |
github-actions[bot] commented 2025-11-08 21:21:55 -05:00 (Migrated from github.com)
Copy link

File: src/pages/index.astro

Actionable change: add the hero search/input the MVP claims to have and make it accessible. Example to insert under the hero copy (or adapt to your styles):

<div class="mt-8 max-w-xl mx-auto">
  <label for="search-input" class="sr-only">Search</label>
  <input id="search-input" name="q" type="search" placeholder="What are you looking for?" aria-label="Search" class="w-full rounded-xl px-4 py-3 text-gray-900" />
</div>
  • Use a visible <label> if you prefer (remove sr-only) and ensure the id matches the for.
  • If this input is currently intentionally omitted, please update specs/000-mvp.md to uncheck/clarify the "Large input" item so the checklist matches implementation.
File: `src/pages/index.astro` Actionable change: add the hero search/input the MVP claims to have and make it accessible. Example to insert under the hero copy (or adapt to your styles): ``` <div class="mt-8 max-w-xl mx-auto"> <label for="search-input" class="sr-only">Search</label> <input id="search-input" name="q" type="search" placeholder="What are you looking for?" aria-label="Search" class="w-full rounded-xl px-4 py-3 text-gray-900" /> </div> ``` - Use a visible `<label>` if you prefer (remove `sr-only`) and ensure the `id` matches the `for`. - If this input is currently intentionally omitted, please update `specs/000-mvp.md` to uncheck/clarify the "Large input" item so the checklist matches implementation.
github-actions[bot] commented 2025-11-08 21:27:01 -05:00 (Migrated from github.com)
Copy link

@Pertempto — quick clarification required for src/pages/index.astro vs specs/000-mvp.md:

  • The MVP checklist marks the "Large input at the top of the page" as done in specs/000-mvp.md, but src/pages/index.astro currently has no <input> (or search form). Please either:
    • Add an accessible search/input element in the hero (visible <label for="..."> or aria-label + matching id) and push the change, or
    • Update specs/000-mvp.md to uncheck/clarify the item and update the PR description so the checklist matches implementation.

If you plan to add the input, reply which behaviour you want (pure search UI vs creation/request form) and I can suggest the exact markup to insert under the hero.

@Pertempto — quick clarification required for `src/pages/index.astro` vs `specs/000-mvp.md`: - The MVP checklist marks the "Large input at the top of the page" as done in `specs/000-mvp.md`, but `src/pages/index.astro` currently has no `<input>` (or search form). Please either: - Add an accessible search/input element in the hero (visible `<label for="...">` or `aria-label` + matching `id`) and push the change, or - Update `specs/000-mvp.md` to uncheck/clarify the item and update the PR description so the checklist matches implementation. If you plan to add the input, reply which behaviour you want (pure search UI vs creation/request form) and I can suggest the exact markup to insert under the hero.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
kwila/market!15
No description provided.