kwila/karriba
Watch
1
1
Fork
You've already forked karriba
 0
Code Pull requests 1 Releases 17 Activity Actions

docs(specs): approve spec 002 #134

Merged
julian merged 4 commits from :spec/002-approve into main 2026-01-31 20:53:56 -05:00
Conversation 1 Commits 4 Files changed 2 +51 -42
dev-bot commented 2026-01-31 17:00:35 -05:00
Collaborator
Copy link

Marks spec 002 (Core Entities Schema) as approved.

This PR contains final spec adjustments, but reviewer should read the entire spec, not just the diff.

Review Checklist for @julian

  • Entities section: Operator, Farm, Address, Parcel, Crop, Season definitions look correct
  • Extension Tables: ApplicatorLicense structure is appropriate
  • Record Changes: FK changes (operator_id, farm_id, parcel_id, crop_id, season_id) make sense
  • Design Decisions:
    • UUIDv7 for primary keys (for future sync)
    • Normalization for migration (trim + lowercase)
    • SQLite ALTER TABLE workarounds
    • Archival vs Deletion policy
    • Archive cascade (UI only, not DB)
    • FK behaviors (RESTRICT/SET NULL)
    • No unique name constraints (for sync)
    • Import/export backward compatibility
    • UTC timezone for dates
  • Task List: Phases 1-4 are clear and at right granularity
  • No concerns about the design
  • Everything is clear for implementation

Once reviewed, update approval_date from TBD to the current date.

Marks spec 002 (Core Entities Schema) as approved. This PR contains final spec adjustments, but **reviewer should read the entire spec**, not just the diff. ## Review Checklist for @julian - [x] Entities section: Operator, Farm, Address, Parcel, Crop, Season definitions look correct - [x] Extension Tables: ApplicatorLicense structure is appropriate - [x] Record Changes: FK changes (operator_id, farm_id, parcel_id, crop_id, season_id) make sense - [x] Design Decisions: - [x] UUIDv7 for primary keys (for future sync) - [x] Normalization for migration (trim + lowercase) - [x] SQLite ALTER TABLE workarounds - [x] Archival vs Deletion policy - [x] Archive cascade (UI only, not DB) - [x] FK behaviors (RESTRICT/SET NULL) - [x] No unique name constraints (for sync) - [x] Import/export backward compatibility - [x] UTC timezone for dates - [x] Task List: Phases 1-4 are clear and at right granularity - [x] No concerns about the design - [x] Everything is clear for implementation Once reviewed, update `approval_date` from TBD to the current date.
Co-authored-by: Shelley <[email protected]>
dev-bot force-pushed spec/002-approve from bfdb8a7f8d to cdbbc2173a 2026-01-31 17:00:58 -05:00 Compare 
Co-authored-by: Shelley <[email protected]>
Co-authored-by: Shelley <[email protected]>
Co-authored-by: Shelley <[email protected]>
addison requested review from julian 2026-01-31 17:27:01 -05:00
addison self-assigned this 2026-01-31 17:27:05 -05:00
julian approved these changes 2026-01-31 20:53:09 -05:00
julian merged commit e94510d484 into main 2026-01-31 20:53:56 -05:00
julian referenced this pull request from a commit 2026-01-31 20:53:57 -05:00
docs(specs): approve spec 002 (#134)
Sign in to join this conversation.
Reviewers
No reviewers
julian
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
addison
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kwila/karriba!134
No description provided.