feat: local data model and storage (spec 1.3) #6

Merged

addison merged 17 commits from implement-spec-1-3-storage into main 2026-07-03 09:50:19 -04:00

Conversation 0 Commits 17 Files changed 19 +1980 -5

dev-bot commented 2026-07-03 06:55:21 -04:00

Collaborator

Copy link

Implements spec 001-mvp/003 Local Data Model and Storage.

Delivered

• Storage foundation: data dir (Documents/shed-ledger via adrg/xdg), modernc.org/sqlite, user_version migration runner, MVP schema migration + seeded statuses, ErrNewerSchema forward-compat guard
• Repository operations: customer/feature/model CRUD, status list, building CRUD with serial lookup + feature join handling, photo metadata ops
• Photo file management under photos// kept in step with the photo table (transactional add with cleanup, delete removes row+file, building delete removes dir)
• App wiring in main.go: open store on startup, graceful launch on newer-schema or open failure so Updates page stays reachable
• Review pass applied (RFC3339 consistency, redundant index removed, dead code removed, extra FK test coverage)
• Spec marked completed

Verification

• go build ./..., go vet ./..., gofmt clean
• GOOS=windows go build ./... (pure-Go driver cross-compiles)
• go test ./internal/storage/ — 15 tests covering schema, seeding, migrations, forward-compat guard, all repos, FK behaviors, photo files

Implements [spec 001-mvp/003 Local Data Model and Storage](specs/001-mvp/003-local-data-model-and-storage/SPEC.md). ## Delivered - [x] Storage foundation: data dir (Documents/shed-ledger via adrg/xdg), modernc.org/sqlite, user_version migration runner, MVP schema migration + seeded statuses, ErrNewerSchema forward-compat guard - [x] Repository operations: customer/feature/model CRUD, status list, building CRUD with serial lookup + feature join handling, photo metadata ops - [x] Photo file management under photos/<building-id>/ kept in step with the photo table (transactional add with cleanup, delete removes row+file, building delete removes dir) - [x] App wiring in main.go: open store on startup, graceful launch on newer-schema or open failure so Updates page stays reachable - [x] Review pass applied (RFC3339 consistency, redundant index removed, dead code removed, extra FK test coverage) - [x] Spec marked completed ## Verification - `go build ./...`, `go vet ./...`, `gofmt` clean - `GOOS=windows go build ./...` (pure-Go driver cross-compiles) - `go test ./internal/storage/` — 15 tests covering schema, seeding, migrations, forward-compat guard, all repos, FK behaviors, photo files

dev-bot added 2 commits 2026-07-03 06:55:21 -04:00

docs: mark spec 003 local data model and storage in-progress ... 0803a608a3

Co-authored-by: Shelley <[email protected]>

feat(storage): add storage package foundation with sqlite migrations ... 4641c01889

- app-managed data dir in Documents/shed-ledger via adrg/xdg
- pure-Go modernc.org/sqlite driver with foreign_keys + WAL pragmas
- user_version migration runner with ErrNewerSchema forward-compat guard
- MVP migration: full schema, serial unique index, seeded statuses

Co-authored-by: Shelley <[email protected]>

dev-bot changed title from feat: local data model and storage (spec 1.3) to WIP: feat: local data model and storage (spec 1.3) 2026-07-03 06:55:27 -04:00

dev-bot added 1 commit 2026-07-03 07:25:13 -04:00

feat(storage): add repository operations for schema entities ... 4285b13dca

- CRUD for customer, feature, model; list for seeded statuses
- building CRUD with serial lookup, trim/empty/duplicate serial errors,
  and feature attachment via building_feature join
- photo metadata operations ordered by sort_order, created_at
- shared ErrNotFound/ErrSerialRequired/ErrSerialTaken sentinels

Co-authored-by: Shelley <[email protected]>

dev-bot added 1 commit 2026-07-03 07:31:46 -04:00

feat(storage): manage photo files on disk alongside photo rows ... d01f51aa2a

- AddPhoto writes photos/<building-id>/<id>.<ext> and inserts the row
  transactionally, cleaning up the file on failure
- DeletePhoto removes row then file; missing file tolerated
- deleting a building removes its photo directory tree
- PhotoPath exposes on-disk location for later serving

Co-authored-by: Shelley <[email protected]>

dev-bot added 1 commit 2026-07-03 07:34:11 -04:00

feat: open local storage on app startup ... 939a478285

Launches gracefully without building data when the database schema is
newer than the app (forward-compatibility guard) or the store fails to
open, so the Updates page stays reachable.

Co-authored-by: Shelley <[email protected]>

dev-bot added 1 commit 2026-07-03 07:46:29 -04:00

fix(storage): apply review fixes to storage layer ... 0a0b320ffc

- use RFC3339 second-precision now() everywhere, incl. seeded statuses
- drop redundant inline UNIQUE; keep named serial-number unique index
- remove unused CreatePhoto and duplicate GetBySerialNumber
- guard test also asserts -wal/-shm untouched on newer-schema open
- add FK coverage: feature delete cascade, model/status SET NULL

Co-authored-by: Shelley <[email protected]>

dev-bot added 1 commit 2026-07-03 07:46:38 -04:00

docs: mark spec 003 local data model and storage completed ... 067bf99341

Co-authored-by: Shelley <[email protected]>

dev-bot changed title from WIP: feat: local data model and storage (spec 1.3) to feat: local data model and storage (spec 1.3) 2026-07-03 07:46:47 -04:00

dev-bot added 1 commit 2026-07-03 08:04:49 -04:00

feat: surface storage availability via /api/health ... 03f9f893b9

- backend serves GET /api/health with available/updateRequired/message
- app layout fetches health on load and shows a danger banner when
  storage is unavailable, with a Go to Updates link when the database
  schema is newer than the app
- buildings routes are gated (content and New Building action) while
  storage is unavailable; Updates page stays fully usable

Co-authored-by: Shelley <[email protected]>

dev-bot added 1 commit 2026-07-03 08:05:20 -04:00

test: cover /api/health storage status responses ... e416bb6965

Co-authored-by: Shelley <[email protected]>

dev-bot added 1 commit 2026-07-03 08:13:36 -04:00

fix: fetch backend health without blocking page render ... d8a885a7e2

- move /api/health fetch from layout load to onMount so routes
  (especially Updates) render immediately
- rename storage-status naming to health/backendStatus: the endpoint
  reports overall backend availability, not just storage

Co-authored-by: Shelley <[email protected]>

dev-bot added 1 commit 2026-07-03 08:19:21 -04:00

fix: show backend-unavailable message only on building routes ... 84856c19d1

Drop the app-wide banner; it duplicated the buildings-page card and
appeared on the Updates page, which must stay clean for updating.

Co-authored-by: Shelley <[email protected]>

dev-bot added 1 commit 2026-07-03 09:19:52 -04:00

chore: merge main into implement-spec-1-3-storage 621dbade19

addison added 1 commit 2026-07-03 09:34:54 -04:00

Merge branch 'main' into implement-spec-1-3-storage 64417300df

addison added 1 commit 2026-07-03 09:37:53 -04:00

fix: photo removal cd970fa6f5

dev-bot added 3 commits 2026-07-03 09:42:51 -04:00

Merge remote-tracking branch 'origin/main' into implement-spec-1-3-storage a485ef77c0

Merge remote-tracking branch 'origin/implement-spec-1-3-storage' into implement-spec-1-3-storage 388a338938

fix: skip permission-based cleanup tests when running as root ... 56194fdc13

Root ignores directory write permissions, so the chmod-0555 setup
cannot force a removal failure in CI containers.

Co-authored-by: Shelley <[email protected]>

addison merged commit 6718c010e3 into main 2026-07-03 09:50:19 -04:00

addison referenced this pull request from a commit 2026-07-03 09:50:20 -04:00

feat: local data model and storage (spec 1.3) (#6)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

kwila/shed-ledger!6

No description provided.