kwila/office-extensions
Watch
1
0
Fork
You've already forked office-extensions
 0
Code Issues Pull requests Projects Releases Packages Activity Actions

docs: sales dashboard spec #54

Merged
addison merged 7 commits from docs-spec-7 into main 2026-09-19 12:21:27 -04:00
Conversation 6 Commits 7 Files changed 10 +246
addison commented 2026-09-18 05:24:51 -04:00
Owner
Copy link
  • Add placeholder dashboards section
  • Add placeholder sales dashboard page
  • Add spec 7 and child specs
- Add placeholder dashboards section - Add placeholder sales dashboard page - Add spec 7 and child specs
Amp-Thread-ID: https://ampcode.com/threads/T-01a0b3a6-acc5-73bb-8dbe-9ab55b6e246d
Co-authored-by: Addison Emig <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0b3a6-acc5-73bb-8dbe-9ab55b6e246d
Co-authored-by: Addison Emig <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0b3a6-acc5-73bb-8dbe-9ab55b6e246d
Co-authored-by: Addison Emig <[email protected]>
docs(spec): clarify dashboard API errors
All checks were successful
CI / frontend (pull_request) Successful in 36s
Details
CI / backend (pull_request) Successful in 35s
Details
5d134c2339
 
Amp-Thread-ID: https://ampcode.com/threads/T-01a0b3a6-acc5-73bb-8dbe-9ab55b6e246d
Co-authored-by: Addison Emig <[email protected]>
addison reviewed 2026-09-18 05:25:37 -04:00
specs/007-dashboards/000-sales-dashboard/000-total-sales-by-department/SPEC.md
@ -0,0 +27,4 @@
### Department Eligibility
- Chosen: Apply the existing sales-report eligibility rules: exclude HVAC Sales and Electric Sales, finance-charge invoices, and progress-billing invoices from the department totals.
addison commented 2026-09-18 05:25:37 -04:00
Author
Owner
Copy link

Confirming this with the customer...

Confirming this with the customer...
addison marked this conversation as resolved
addison reviewed 2026-09-18 05:25:42 -04:00
specs/007-dashboards/000-sales-dashboard/001-annual-total-sales-by-employee/SPEC.md
@ -0,0 +30,4 @@
### Employee Sales Eligibility
- Chosen: Apply the existing sales-report eligibility rules: exclude HVAC Sales and Electric Sales, finance-charge invoices, and progress-billing invoices from employee totals.
addison commented 2026-09-18 05:25:42 -04:00
Author
Owner
Copy link

Confirming this with the customer...

Confirming this with the customer...
addison marked this conversation as resolved
docs(spec): add performance department filter
All checks were successful
CI / frontend (pull_request) Successful in 37s
Details
CI / backend (pull_request) Successful in 35s
Details
cb86de6436
 
Amp-Thread-ID: https://ampcode.com/threads/T-01a0b3a6-acc5-73bb-8dbe-9ab55b6e246d
Co-authored-by: Addison Emig <[email protected]>
docs(spec): clarify department filter interaction
All checks were successful
CI / frontend (pull_request) Successful in 36s
Details
CI / backend (pull_request) Successful in 35s
Details
5e37ce9d9f
 
Amp-Thread-ID: https://ampcode.com/threads/T-01a0b3a6-acc5-73bb-8dbe-9ab55b6e246d
Co-authored-by: Addison Emig <[email protected]>
docs(spec): start dashboard implementations
All checks were successful
CI / frontend (pull_request) Successful in 38s
Details
CI / backend (pull_request) Successful in 36s
Details
63a52deddb
 
Amp-Thread-ID: https://ampcode.com/threads/T-01a0b3a6-acc5-73bb-8dbe-9ab55b6e246d
Co-authored-by: Addison Emig <[email protected]>
addison commented 2026-09-18 05:34:54 -04:00
Author
Owner
Copy link

@talha please take a look at the new specs and let me know if you have any questions! then i can fix before I merge

@talha please take a look at the new specs and let me know if you have any questions! then i can fix before I merge
addison self-assigned this 2026-09-18 05:35:07 -04:00
addison requested review from talha 2026-09-18 05:35:07 -04:00
talha commented 2026-09-18 06:03:53 -04:00
Collaborator
Copy link

@addison wrote in #54 (comment):

@talha please take a look at the new specs and let me know if you have any questions! then i can fix before I merge

Overall looks fine, I went through each specs and files, however during implementation there can be some minute confusions or adversities which can be taken care of at that time.

@addison wrote in https://git.kwila.cloud/kwila/office-extensions/pulls/54#issuecomment-4924: > @talha please take a look at the new specs and let me know if you have any questions! then i can fix before I merge Overall looks fine, I went through each specs and files, however during implementation there can be some minute confusions or adversities which can be taken care of at that time.
talha approved these changes 2026-09-18 06:04:11 -04:00
addison commented 2026-09-18 18:09:22 -04:00
Author
Owner
Copy link

Sounds good! I'm still waiting to hear from customer about including/excluding FC/PB invoices.

Sounds good! I'm still waiting to hear from customer about including/excluding FC/PB invoices.
addison deleted branch docs-spec-7 2026-09-19 12:21:28 -04:00
addison referenced this pull request from a commit 2026-09-19 12:21:29 -04:00
docs: sales dashboard spec (#54)
Sign in to join this conversation.
Reviewers
No reviewers
talha
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
addison
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kwila/office-extensions!54
No description provided.