kwila/office-extensions
Watch
1
0
Fork
You've already forked office-extensions
 0
Code Issues Pull requests 1 Projects Releases Packages Activity Actions

perf: improved copy feedback #37

Merged
addison merged 5 commits from 004-001-002-copy-feedback-reliability into main 2026-08-13 03:35:00 -04:00
Conversation 3 Commits 5 Files changed 3 +34 -5
talha commented 2026-08-08 13:43:14 -04:00
Collaborator
Copy link

Spec 4.1.2

Changes

  • added feedback timout ref to track overlapping copied feedbacks.
  • added state increment for key of feedback to restart feedback component to avoid flickering of feedback text.

Testing

  • Make sure you have latest code running.
  • Navigate to sales report.
  • Click on a cell, 'Copied!' popup must be shown, try clicking same cell multiple time, it must restart 2 second timer of popup.
# Spec 4.1.2 ## Changes - added feedback timout ref to track overlapping copied feedbacks. - added state increment for key of feedback to restart feedback component to avoid flickering of feedback text. ## Testing - [x] Make sure you have latest code running. - [x] Navigate to sales report. - [x] Click on a cell, 'Copied!' popup must be shown, try clicking same cell multiple time, it must restart 2 second timer of popup.
perf: improved copy feedback
All checks were successful
Amp Review / review (pull_request) Successful in 1s
Details
53bcab805b
talha requested review from addison 2026-08-08 13:43:30 -04:00 
Amp-Thread-ID: https://ampcode.com/threads/T-019feffc-d3ae-731a-8b9d-49f6ac8a64bd
Co-authored-by: Addison Emig <[email protected]>
addison commented 2026-08-11 04:50:06 -04:00
Owner
Copy link

There is an unmount race found by the dev bot, please see the new test case for reproduction.

There is an unmount race found by the dev bot, please see the new test case for reproduction.
Merge branch 'main' into 004-001-002-copy-feedback-reliability
Some checks failed
CI / frontend (pull_request) Failing after 27s
Details
CI / backend (pull_request) Has been skipped
Details
d3450766ac
addison commented 2026-08-11 04:56:50 -04:00
Owner
Copy link

The new test case is in CopyableCell.test.tsx

I added it to main in #39, because I needed at least one test case for new frontend tests.

The new test case is in `CopyableCell.test.tsx` I added it to main in #39, because I needed at least one test case for new frontend tests.
fix: prevent state updates after unmount in CopyableCell component
All checks were successful
CI / frontend (pull_request) Successful in 31s
Details
CI / backend (pull_request) Successful in 37s
Details
Amp Review / review (pull_request) Successful in 3s
Details
f9118df09d
addison commented 2026-08-11 18:45:40 -04:00
Owner
Copy link

Please fix conflicts

Please fix conflicts
Merge branch 'main' of https://git.kwila.cloud/kwila/office-extensions into 004-001-002-copy-feedback-reliability
All checks were successful
CI / frontend (pull_request) Successful in 35s
Details
CI / backend (pull_request) Successful in 40s
Details
e572b1f381
addison deleted branch 004-001-002-copy-feedback-reliability 2026-08-13 03:35:00 -04:00
addison referenced this pull request from a commit 2026-08-13 03:35:00 -04:00
perf: improved copy feedback (#37)
Sign in to join this conversation.
Reviewers
No reviewers
addison
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kwila/office-extensions!37
No description provided.