feat: basic connections system #66

Merged

addison merged 35 commits from exe-dev-bot/market:feat/basic-connections into main 2026-01-22 11:49:44 -05:00

Conversation 0 Commits 35 Files changed 32 +2370 -283

addison commented 2026-01-16 21:02:16 -05:00

Owner

Copy link

No description provided.

addison added 7 commits 2026-01-16 21:02:16 -05:00

feat: implement connection system ... 076f80e442

- Rename connection columns user_a/user_b to initiator_id/receiver_id
- Add rate limiting function can_create_connection_request()
- Add get_connection_status() RPC for checking connection state
- Update RLS policies for role-based delete permissions
- Create API endpoints for connections (POST, PATCH, DELETE)
- Add ConnectButton component with confirmation dialog
- Add ConnectionActions for accept/decline/withdraw
- Add ProfileShare with QR code and Web Share API
- Update connections page with incoming/outgoing sections
- Add connection status display on profile pages
- Update all queries to use new column names

Co-authored-by: Shelley <shelley@exe.dev>

chore: re-enable CI workflow bc52e58845

fix(ci): use npx astro dev instead of just for E2E tests ... 1ad62e5e29

The CI environment doesn't have 'just' installed, causing E2E tests
to fail with exit code 127 (command not found).

Co-authored-by: Shelley <shelley@exe.dev>

perf(ci): use container images with Node.js pre-installed ... 453929d5cf

- Use node:20-bookworm for lint, type-check, format-check, unit-tests
- Use mcr.microsoft.com/playwright:v1.52.0-noble for E2E tests
- Remove setup-node steps and Playwright browser install steps
- This eliminates Node.js download/setup time in each job

Co-authored-by: Shelley <shelley@exe.dev>

revert(ci): remove container images, keep original workflow ... 338d197aef

Container syntax may not work with Forgejo act runner.

Co-authored-by: Shelley <shelley@exe.dev>

Revert "revert(ci): remove container images, keep original workflow" ... dc26fe3e00

This reverts commit 338d197aef.

fix(ci): update Playwright image to v1.56.1-noble ... 40224ff75c

Playwright was updated to 1.56.1 but the CI was using v1.52.0-noble
Docker image, causing browser executable not found errors.

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-16 21:07:27 -05:00

perf(ci): combine lint/typecheck/format jobs and add concurrency ... ee80ef9439

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-16 21:22:24 -05:00

fix(test): make category filter test case-insensitive ... ca9b26859b

The E2E test was checking for 'category' (lowercase) but the page
displays 'Categories' (capitalized). Since the test runs without a
real database, there are no category buttons rendered, only the label.

Also added Forgejo CI API documentation to AGENTS.md.

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-16 21:26:04 -05:00

style: fix formatting in AGENTS.md and test file ... ab21962a23

Co-authored-by: Shelley <shelley@exe.dev>

addison added 4 commits 2026-01-17 05:11:37 -05:00

feat: implement re-initiation flow and add comprehensive connection system tests ... 1bb1283994

- Fix ConnectButton to delete declined connection before re-initiating (blocked_by_me flow)
- Add 57 unit tests for connection system covering rate limiting, status logic, API responses, business rules, and validation
- Add 30+ E2E test scenarios for complete connection workflows
- Tests cover: rate limiting, accept/decline flows, withdrawal, blocking, re-initiation, UI states, and RLS visibility

Implements spec-002 testing & refinement tasks (items 96-102)

docs: mark spec-002 as completed ... b3e1464deb

All connection system features implemented and tested:
- API endpoints with rate limiting
- Database schema and RLS policies
- Profile page integration
- Re-initiation flow fixed
- 87 comprehensive tests (unit + E2E)

fix: use separate queries for connections OR logic ... 0f5209c804

Changed getUserConnections to query initiator and receiver separately
instead of using .or() which wasn't working correctly. This fixes the
regression where connections were not shown on the /connections page.

fix: fetch user details separately for connections display ... c819c51628

Changed getUserConnections to fetch connection data separately from user
details to avoid Supabase foreign key relationship issues. This properly
reconstructs initiator/receiver objects for the connections page display.

addison added 2 commits 2026-01-17 05:21:52 -05:00

fix: remove errant migration 7958086247

fix: missing policies b8355aca86

exe-dev-bot force-pushed feat/basic-connections from b8355aca86 to 7b93ff7d6a 2026-01-22 05:49:20 -05:00 Compare

exe-dev-bot added 1 commit 2026-01-22 06:03:04 -05:00

fix: use createSupabaseBrowserClient in ConnectionActions ... 2990e960fb

Replace direct createClient() usage with createSupabaseBrowserClient()
to properly handle auth session via cookie storage. This fixes the
'Not authenticated' error in connection accept/decline/withdraw actions.

Also document Supabase client creation patterns in AGENTS.md to prevent
similar mistakes in the future.

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-22 06:04:31 -05:00

fix: use createSupabaseBrowserClient in ConnectButton ... b06af96818

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-22 06:11:18 -05:00

fix: track connectionId in state for withdraw after connect ... 494d4dbdca

Also add doc comments explaining the context each component is used in.

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 3 commits 2026-01-22 06:24:42 -05:00

fix: make pending connection requests clickable ... 8ed74529c7

Co-authored-by: Shelley <shelley@exe.dev>

fix: use platformName constant in ProfileShare ... 1f3d0aef86

Co-authored-by: Shelley <shelley@exe.dev>

refactor: move ProfileShare from dashboard to user profile page ... ba5b2165c3

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 2 commits 2026-01-22 06:31:03 -05:00

refactor: reorganize dashboard links and add edit button to profile ... 11aa9e833f

Co-authored-by: Shelley <shelley@exe.dev>

feat: show pending connection request count on dashboard ... aee6c89ffc

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 3 commits 2026-01-22 06:35:56 -05:00

style: make link badge larger ... 87f4be0c18

Co-authored-by: Shelley <shelley@exe.dev>

refactor: show pending requests above active connections ... 07e23196b4

Co-authored-by: Shelley <shelley@exe.dev>

feat: add share profile modal with QR code loading state ... 1b6ed034ed

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-22 06:40:26 -05:00

refactor: move share to header button with modal, improve badge styling ... d25f8b25f9

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-22 06:52:13 -05:00

fix: only show badge when count > 0 ... 1ed59d36cb

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-22 06:58:36 -05:00

fix: refresh page after declining connection to show in Past Connections ... ea1a8d8aba

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-22 06:59:39 -05:00

refactor: rename Past to Declined Connections, make clickable ... fefe707f61

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-22 07:16:23 -05:00

fix(connections): fix Send Connection Request button for declined connections ... 1ce2fa3a54

The button for re-initiating a connection after previously declining
wasn't working due to two issues:

1. UI Bug: The blocked_by_me status case returned early without
   rendering the confirmation dialog when showConfirmation was true.
   Fixed by including the confirmation dialog UI in the blocked_by_me
   case.

2. API Flow Bug: Re-initiation requires first DELETEing the existing
   declined connection before POSTing a new one. Added logic to
   handleConnect to detect re-initiation scenario and delete the
   existing connection first.

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-22 07:26:02 -05:00

refactor(components): extract Badge component for reuse ... 8ad0f31cd0

- Create Badge.astro component with count and class props
- Update LinkCard.astro to use Badge component
- Update ConnectionsList.astro to use Badge for Incoming/Outgoing counts

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-22 07:30:54 -05:00

test: add E2E tests for connections-only visibility ... d84c5d1a07

- Test that connected users can see connections-only contact info
- Test that non-connected users cannot see connections-only contact info
- Test that public contact info is visible to everyone
- Test that users can see their own connections-only info
- Skip rate limiting test (requires fresh user creation)

Mark spec-002 testing section as complete.

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-22 11:09:25 -05:00

test: remove skipped rate limiting test ... e20e95f87c

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-22 11:12:07 -05:00

chore: add Sam, Ralph, and Tina test users for rate limit testing ... 696c5cfd2d

- Sam: invited by Eve
- Ralph: invited by Alice (only connected to Alice, can try 6 others)
- Tina: invited by Bob

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot force-pushed feat/basic-connections from 696c5cfd2d to a9a0324fba 2026-01-22 11:22:17 -05:00 Compare

exe-dev-bot force-pushed feat/basic-connections from a9a0324fba to 4a4a44c00c 2026-01-22 11:23:57 -05:00 Compare

exe-dev-bot added 1 commit 2026-01-22 11:28:32 -05:00

docs: mark rate limiting test as complete ... 93e208211d

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-22 11:30:27 -05:00

refactor: use shared Button component in ProfileShareButton ... 81a0be1b94

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-22 11:32:46 -05:00

refactor: use shared Button component for modal close and edit profile link ... 6d83000245

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-22 11:46:10 -05:00

fix: refresh page after withdrawing connection request ... 4e2fb2c59f

Co-authored-by: Shelley <shelley@exe.dev>

exe-dev-bot added 1 commit 2026-01-22 11:49:19 -05:00

docs: update spec 7eed9d6cde

addison merged commit 0f3c36d1ec into main 2026-01-22 11:49:44 -05:00

addison deleted branch feat/basic-connections 2026-01-22 11:49:44 -05:00

addison referenced this pull request from a commit 2026-01-22 11:49:46 -05:00

feat: basic connections system (#66)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

kwila/market!66

No description provided.