feat: implement user profile system #40

Merged

addison merged 48 commits from feature/user-profile into main 2025-12-24 13:37:55 -05:00

Conversation 0 Commits 48 Files changed 51 +3908 -171

addison commented 2025-12-24 07:08:24 -05:00

Owner

Copy link

• Add theme persistence to database with localStorage migration
• Create API endpoints for saving user settings and profile updates
• Implement contact info management with dialog-based editing
• Add /profile/edit page for profile editing
• Add /profile/[user_id] page for viewing user profiles
• Add /{vendor_id} route for public vendor profiles
• Update dashboard with 'Edit Profile' quick action link
• Add validation for vendor_id (alphanumeric + hyphens, 3-50 chars)
• RLS policies enforce visibility rules for contact info
• All features pass type-check, lint, and format checks

- Add theme persistence to database with localStorage migration - Create API endpoints for saving user settings and profile updates - Implement contact info management with dialog-based editing - Add /profile/edit page for profile editing - Add /profile/[user_id] page for viewing user profiles - Add /{vendor_id} route for public vendor profiles - Update dashboard with 'Edit Profile' quick action link - Add validation for vendor_id (alphanumeric + hyphens, 3-50 chars) - RLS policies enforce visibility rules for contact info - All features pass type-check, lint, and format checks

addison added 1 commit 2025-12-24 07:08:24 -05:00

feat: implement user profile system with settings persistence ... d87cc15592

- Add theme persistence to database with localStorage migration
- Create API endpoints for saving user settings and profile updates
- Implement contact info management with dialog-based editing
- Add /profile/edit page for profile editing
- Add /profile/[user_id] page for viewing user profiles
- Add /{vendor_id} route for public vendor profiles
- Update dashboard with 'Edit Profile' quick action link
- Add validation for vendor_id (alphanumeric + hyphens, 3-50 chars)
- RLS policies enforce visibility rules for contact info
- All features pass type-check, lint, and format checks

addison added 2 commits 2025-12-24 08:45:18 -05:00

feat: confirmatation dialog for deleting contact infO ffa719458e

refactor: dialog system bf7dd45d45

addison added 2 commits 2025-12-24 09:23:44 -05:00

refactor: contact info dialog 89ba50c59d

refactor: developer docs 35f0819055

addison added 1 commit 2025-12-24 09:35:43 -05:00

refactor: vendor profile pages 90d06ccf9b

addison added 1 commit 2025-12-24 09:52:16 -05:00

fix(storage): use signed URLs for avatar display on profile pages feec918b48

addison added 1 commit 2025-12-24 09:55:00 -05:00

feat: improve profile buttons 3cb816956f

addison added 1 commit 2025-12-24 09:58:48 -05:00

fix: remove redundant contact info filtering from profile pages ... 417585c980

RLS policies already enforce visibility at the database level. Remove
post-fetch filtering from both user profile and vendor pages to rely
entirely on RLS for security enforcement.

addison added 1 commit 2025-12-24 10:00:06 -05:00

feat: add visibility badges to contact info on profile pages ... 2287430d26

Display inline badges showing whether each contact is Public, Connections-only,
or Hidden. This clarifies visibility settings when users view their own profiles.

addison added 1 commit 2025-12-24 10:00:46 -05:00

feat: add copy-to-clipboard buttons on contact info ... 11e9e80b4d

Add CopyButton component that lets users quickly copy contact info on both
profile pages. Button shows hover tooltip and brief success feedback with
a checkmark icon when clicked.

addison added 4 commits 2025-12-24 10:34:46 -05:00

feat: improve profiles f5043d8918

feat: add 'View As' selector to own profile page ... d778f215d9

Allow users to preview how their profile appears to different audiences:
- Myself (full access, including hidden contacts)
- A Connection (connections-only contacts visible)
- Public (public contacts only)

The selector only appears when viewing your own profile and uses RLS
policies to enforce correct visibility at the database level.

refactor: move contact filtering into ContactInfoSection component ... dae7223acc

Instead of a separate FilteredContactInfo component, add viewAs prop
directly to ContactInfoSection for cleaner code. Now filtering is
handled server-side in the Astro component.

fix: no need for vendor ID on user profile page 99b4a1dae9

addison added 1 commit 2025-12-24 10:41:48 -05:00

fix: invite page 82d0ebd44d

addison added 1 commit 2025-12-24 10:46:11 -05:00

docs: wrapper pattern e4a1d98317

addison added 1 commit 2025-12-24 10:53:16 -05:00

fix: address review feedback ed13b6fb1a

addison added 1 commit 2025-12-24 10:55:28 -05:00

fix: address review feedback 1d39fed260

addison added 1 commit 2025-12-24 10:58:35 -05:00

test: validation 69eb6d015e

addison added 1 commit 2025-12-24 10:58:54 -05:00

spec: optimize onboarding e5f6feab87

addison added 17 commits 2025-12-24 11:24:44 -05:00

chore: second iteration review ebf4f2c2a0

fix(security): remove string matching on error messages in profile endpoint ... 5dcd0fd1e1

- Avoid parsing error.message which is fragile and could leak information
- Use error.code directly for constraint violation detection (code 23505)
- Prevents potential security issue where error message format changes could cause bugs

fix(security): prevent error information leakage in theme save ... c8c15eedbd

- Remove response.statusText logging which varies and could leak server info
- Only log critical 5xx errors, silently handle auth/validation errors
- Theme is already saved locally so database failures are non-critical

fix(security): add explicit ownership verification to contact delete endpoint ... 59ee71437d

- Don't rely solely on RLS policies for authorization
- Explicitly verify contact belongs to authenticated user before deletion
- Returns 404 if not found or user not authorized (prevents enumeration)

fix(security): replace XSS-vulnerable storage with URL parameters for auth flow ... 7b9cdf1c43

- Remove sessionStorage use for email in OTPForm (XSS vulnerable)
- Remove localStorage use for invite code in LoginForm
- Pass email and invite code via URL parameters instead
- More secure and doesn't expose data if browser is accessed by others

fix(react): add useCallback to OTPForm event handlers and theme loading ... 5051be3538

- Wrap event handlers (handleCodeChange, handleKeyDown, handlePaste) in useCallback
- Prevents stale closure issues and unnecessary re-renders
- Add theme loading on mount with AbortController cleanup
- Load theme before showing form to avoid FOUC

fix(react): add AbortController to prevent state updates on unmount in ContactInfoForm ... e046eff46d

- Create abort controller for fetch operations
- Cancel pending requests when component unmounts
- Check aborted status before updating state to prevent memory leaks
- Ignore AbortError exceptions from cancelled requests

fix(security): whitelist allowed setting keys in settings API ... 82bb25d6ee

- Define ALLOWED_SETTINGS constant with 'theme', 'notifications', 'language'
- Validate setting_key against whitelist before upsert
- Prevents arbitrary setting injection attacks
- Returns clear error message with allowed values

fix(validation): improve phone number regex pattern ... 32456dc7ce

- Replace loose regex with precise pattern: (optional +1)-(area)-(prefix)-(line)
- Supports formats: 1234567890, (123) 456-7890, 123-456-7890, +1 123 456 7890
- Prevents invalid patterns like '--+--+--' or leading spaces
- Clearer error message

fix(security): use only implemented settings in whitelist ... 7617d974db

- Change ALLOWED_SETTINGS from ['theme', 'notifications', 'language'] to ['theme']
- Only whitelist settings that are actually implemented
- Add comment to note where new settings should be registered
- Prevents future typos or unintended settings

fix(validation): validate contact type values in contact-info API ... f0a31a71fb

- Check that stored contact_type matches enum values ('email', 'phone')
- Prevent silent failures from unexpected database values
- Return 500 error if corrupted contact record is found
- Logged in server error for debugging

fix(validation): validate Astro route parameters with Zod schemas ... 011674374e

- Validate vendor_id with regex /^[a-zA-Z0-9-]+$/ in vendor page
- Validate user_id as UUID format in profile page
- Redirect to home if validation fails instead of passing invalid values to DB
- Prevents invalid values from reaching database queries

fix(react): add useCallback to ProfileEditor handlers ... fd465833ca

- Wrap event handlers in useCallback to prevent stale closures
- Add proper dependency arrays for all handlers
- Prevents unnecessary re-renders and closures over stale state

fix(validation): improve phone regex to support international formats ... c46863c4f8

- Use permissive character set with minimum 10 digits check
- Support formats: 123-456-7890, (123) 456-7890, +1 123 456 7890, +44 20 7946 0958
- Secondary validation checks digit count after removing non-digits
- More flexible than strict pattern matching

fix(types): resolve all TypeScript errors ... 3bd78b28fa

- Fix ViewAsSelector URL creation with window.location.href instead of Location object
- Add type assertions in DialogRenderer to satisfy discriminated union types
- Convert AstroCookies to empty Record for getPublicUrlServer compatibility
- Remove unused userId prop from ViewAsSelector component
- All type-check errors now resolved

refactor: remove unused cookies parameter from getPublicUrlServer ... f0d14b919d

- Remove _cookies parameter that was never used
- Simplifies function signature and calls
- Only cookieHeader was ever needed for the function logic

feat: add disable vendor profile button ... 9db56dbcd2

- Add setValue import from useForm to enable clearing vendor_id
- Add "Disable Vendor Profile" button with danger variant
- Restructure vendor profile buttons into flex column layout
- Allow users to clear vendor_id and opt out of vendor profile

addison added 1 commit 2025-12-24 11:28:59 -05:00

docs: improvements 07330b7f83

addison added 1 commit 2025-12-24 11:30:59 -05:00

docs: trim dialog docs 39a791be6c

addison added 1 commit 2025-12-24 11:34:20 -05:00

fix: default value 251241ca55

addison added 3 commits 2025-12-24 11:46:16 -05:00

refactor: replace generic getPublicUrlServer with getAvatarSignedUrl ... 84e2e241b9

- Rename getPublicUrlServer to getAvatarSignedUrl for clarity
- Add strict path validation using UUID and filename regex
- Prevents path traversal attacks (../, ./, special chars)
- Remove unnecessary cookieHeader parameter
- Add comprehensive unit tests (31 test cases)
- Tests cover valid paths, traversal attempts, UUID validation, filename validation

test: add security tests for item/message image access prevention ... 247e1d9634

- Add 5 new security test cases ensuring items/ folder cannot be accessed
- Test direct item image path rejection
- Test message image path rejection
- Test path traversal attempts (../ sequences)
- Test mixed folder access attempts
- Brings total to 36 test cases
- All tests pass

chore: update pre-commit hooks to use just recipes ... 57eec055c4

- Replace npm run scripts with just recipes
- format hook now runs: just format
- lint hook now runs: just lint
- Add test-unit-file recipe for running specific test files
- Consistency with project development workflow

addison added 4 commits 2025-12-24 13:34:05 -05:00

fix: disable vendor profile button when vendor_id field is dirty 3c3c491b46

feat: privacy policy 318aa66043

feat: better avatar handling 5ae1b4122e

chore: upgrade packages c0c6d1816c

addison changed title from feat: implement user profile system with settings persistence to feat: implement user profile system 2025-12-24 13:37:47 -05:00

addison merged commit 93968301a6 into main 2025-12-24 13:37:55 -05:00

addison deleted branch feature/user-profile 2025-12-24 13:37:55 -05:00

addison referenced this pull request from a commit 2025-12-24 13:37:57 -05:00

feat: implement user profile system (#40)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

kwila/market!40

No description provided.