kwila/market
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: set up dev scripts #30

Merged
Pertempto merged 10 commits from setup-dev-scripts into main 2025-11-19 08:16:48 -05:00
Conversation 5 Commits 10 Files changed 7 +101 -41
Pertempto commented 2025-11-19 07:33:54 -05:00 (Migrated from github.com)
Copy link
No description provided.
supabase[bot] commented 2025-11-19 07:34:09 -05:00 (Migrated from github.com)
Copy link

Updates to Preview Branch (setup-dev-scripts) ↗︎

Deployments Status Updated
Database ✅ Wed, 19 Nov 2025 12:45:25 UTC
Services ✅ Wed, 19 Nov 2025 12:45:25 UTC
APIs ✅ Wed, 19 Nov 2025 12:45:25 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations ✅ Wed, 19 Nov 2025 12:45:25 UTC
Migrations ✅ Wed, 19 Nov 2025 12:45:26 UTC
Seeding ✅ Wed, 19 Nov 2025 12:45:27 UTC
Edge Functions ✅ Wed, 19 Nov 2025 12:45:27 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

[supa]:qkophtyqdxtphvgfufrg **Updates to [Preview Branch (setup-dev-scripts) ↗︎](https://supabase.com/dashboard/project/qkophtyqdxtphvgfufrg)** | Deployments | Status | Updated | | ----------- | --------------------------- | ------------------------- | | Database | ✅ | Wed, 19 Nov 2025 12:45:25 UTC | | Services | ✅ | Wed, 19 Nov 2025 12:45:25 UTC | | APIs | ✅ | Wed, 19 Nov 2025 12:45:25 UTC | Tasks are run on every commit but only new migration files are pushed. Close and reopen this PR if you want to apply changes from existing seed or migration files. | Tasks | Status | Updated | | -------------- | ---------------------------- | -------------------------- | | Configurations | ✅ | Wed, 19 Nov 2025 12:45:25 UTC | | Migrations | ✅ | Wed, 19 Nov 2025 12:45:26 UTC | | Seeding | ✅ | Wed, 19 Nov 2025 12:45:27 UTC | | Edge Functions | ✅ | Wed, 19 Nov 2025 12:45:27 UTC | <hr/> View logs for this [Workflow Run ↗︎](https://supabase.com/dashboard/project/qkophtyqdxtphvgfufrg/branches). Learn more about [Supabase for Git ↗︎](https://supabase.com/docs/guides/platform/branching).
github-actions[bot] commented 2025-11-19 07:35:27 -05:00 (Migrated from github.com)
Copy link

AGENTS.md: In the "Database" section you list npm run db:diff, but the updated package.json does not include a db:diff script — only db:types and db:reset were added. Please either add a db:diff script to package.json or remove/update the reference in AGENTS.md so docs and scripts stay consistent.

`AGENTS.md`: In the "Database" section you list `npm run db:diff`, but the updated `package.json` does not include a `db:diff` script — only `db:types` and `db:reset` were added. Please either add a `db:diff` script to `package.json` or remove/update the reference in `AGENTS.md` so docs and scripts stay consistent.
github-actions[bot] commented 2025-11-19 07:35:59 -05:00 (Migrated from github.com)
Copy link

package.json: The new start:backend/stop:backend scripts run the Supabase CLI directly. These CLI commands require the Supabase CLI to be installed or available via npx. Consider one of the following to avoid unexpected failures for contributors:

  • Add a note in CONTRIBUTING.md (or AGENTS.md) that supabase CLI must be installed globally or show using npx supabase start in the script.
  • Or make scripts use npx (e.g. npx supabase start) so they work without global install.

Prefer npx for better DX unless there's a reason to require global install.

`package.json`: The new `start:backend`/`stop:backend` scripts run the Supabase CLI directly. These CLI commands require the Supabase CLI to be installed or available via `npx`. Consider one of the following to avoid unexpected failures for contributors: - Add a note in `CONTRIBUTING.md` (or AGENTS.md) that `supabase` CLI must be installed globally or show using `npx supabase start` in the script. - Or make scripts use `npx` (e.g. `npx supabase start`) so they work without global install. Prefer `npx` for better DX unless there's a reason to require global install.
github-actions[bot] commented 2025-11-19 07:37:08 -05:00 (Migrated from github.com)
Copy link

Changes Requested

Please make the following changes before I approve this PR:

  • Fix the incorrect Supabase migration command in CONTRIBUTING.md (currently npx run supbase db -f <migration-name>). Replace with a correct example and prefer npx supabase ... usage.
  • Make package.json CLI-invoking scripts robust for contributors by using npx (or document global CLI requirements). Add the missing db:diff script referenced in AGENTS.md and tests recommendations.
  • Ensure AGENTS.md and CONTRIBUTING.md references to scripts match package.json after changes (remove any stale references).

Summary of Changes

  • AGENTS.md: Reworked src/ layout, added supabase/ folder layout, replaced generic dev commands with start:frontend/start:backend/db:types/db:reset notes.
  • CONTRIBUTING.md: Added prerequisites, setup steps, and common commands for local dev (Supabase/Playwright related commands added).
  • package.json: Replaced dev/build/test scripts with start:frontend/start:backend/stop:backend/build:frontend, added db:types and db:reset, changed test:e2e to playwright test.
  • specs/000-mvp.md: Marked local dev setup checklist items complete.

Overall Feedback

  • Negative: There are a few doc/script mismatches and at least one broken CLI command that will confuse contributors and cause local workflow failures if not fixed. The package.json scripts call CLIs directly (without npx) which will break for users who don't have those CLIs globally installed. The Supabase migration command in CONTRIBUTING.md is incorrect and must be updated.

  • Positive: Solid work standardizing the local developer workflow and documenting the commands — the new scripts and CONTRIBUTING updates will make onboarding clearer. The repo layout and AGENTS.md improvements improve discoverability and DX. Nice job! 🎉

@Pertempto — please address the three requested fixes and ping me; I'll re-review quickly.

# Changes Requested Please make the following changes before I approve this PR: - Fix the incorrect Supabase migration command in `CONTRIBUTING.md` (currently `npx run supbase db -f <migration-name>`). Replace with a correct example and prefer `npx supabase ...` usage. - Make `package.json` CLI-invoking scripts robust for contributors by using `npx` (or document global CLI requirements). Add the missing `db:diff` script referenced in `AGENTS.md` and tests recommendations. - Ensure `AGENTS.md` and `CONTRIBUTING.md` references to scripts match `package.json` after changes (remove any stale references). ## Summary of Changes - `AGENTS.md`: Reworked `src/` layout, added `supabase/` folder layout, replaced generic dev commands with `start:frontend`/`start:backend`/`db:types`/`db:reset` notes. - `CONTRIBUTING.md`: Added prerequisites, setup steps, and common commands for local dev (Supabase/Playwright related commands added). - `package.json`: Replaced `dev`/`build`/`test` scripts with `start:frontend`/`start:backend`/`stop:backend`/`build:frontend`, added `db:types` and `db:reset`, changed `test:e2e` to `playwright test`. - `specs/000-mvp.md`: Marked local dev setup checklist items complete. ## Overall Feedback - Negative: There are a few doc/script mismatches and at least one broken CLI command that will confuse contributors and cause local workflow failures if not fixed. The `package.json` scripts call CLIs directly (without `npx`) which will break for users who don't have those CLIs globally installed. The Supabase migration command in `CONTRIBUTING.md` is incorrect and must be updated. - Positive: Solid work standardizing the local developer workflow and documenting the commands — the new scripts and CONTRIBUTING updates will make onboarding clearer. The repo layout and AGENTS.md improvements improve discoverability and DX. Nice job! 🎉 @Pertempto — please address the three requested fixes and ping me; I'll re-review quickly.
github-actions[bot] commented 2025-11-19 07:40:37 -05:00 (Migrated from github.com)
Copy link

package.json (scripts): Please make CLI scripts robust by using npx and add the missing db:diff script. Suggested replacements for the scripts entries (you can paste these into package.json):

"start:frontend": "astro dev",
"start:backend": "npx supabase start",
"stop:backend": "npx supabase stop",
"build:frontend": "astro build",
"test:e2e": "npx playwright test",
"db:types": "npx supabase gen types typescript --local > src/lib/database.types.ts",
"db:diff": "npx supabase db diff",
"db:reset": "npx supabase db reset"

This avoids requiring global CLI installs and satisfies the AGENTS.md reference to db:diff. @Pertempto — are you okay with switching to npx here?

`package.json` (scripts): Please make CLI scripts robust by using `npx` and add the missing `db:diff` script. Suggested replacements for the `scripts` entries (you can paste these into `package.json`): "start:frontend": "astro dev", "start:backend": "npx supabase start", "stop:backend": "npx supabase stop", "build:frontend": "astro build", "test:e2e": "npx playwright test", "db:types": "npx supabase gen types typescript --local > src/lib/database.types.ts", "db:diff": "npx supabase db diff", "db:reset": "npx supabase db reset" This avoids requiring global CLI installs and satisfies the `AGENTS.md` reference to `db:diff`. @Pertempto — are you okay with switching to `npx` here?
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
kwila/market!30
No description provided.